[Webkit-unassigned] [Bug 199072] New: Resolve frequent crashes in String::isolatedCopy inside topPrivatelyControlledDomain call

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199072

            Bug ID: 199072
           Summary: Resolve frequent crashes in String::isolatedCopy
                    inside topPrivatelyControlledDomain call
           Product: WebKit
           Version: Safari 10
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: bfulgham at webkit.org

Crash data indicates that we are frequently crashing while performing 'String::isolatedCopy' inside topPrivatelyControlledDomain calls. This seem to be primarily related to multiple threads attempting to initialize RegistrableDomain members at the same time.

Code review showed the potential for a thread contention issue.

This patch resolves the problem in two ways:

(1) A thread safety issue in the implementation of WebCore::topPrivatelyControlledDomain is corrected. (Note: This is an issue because we build WebKit with --fno-threadsafe-statics).
(2) I added a call during NetworkProcess initialization (before spawning multiple threads) to initialize the domain cache. This change is probably not needed, but adds another layer of defense.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190620/fc841616/attachment.html>