[Webkit-unassigned] [Bug 196094] [GTK][WPE] Implement a basic DNS cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=196094

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372453|review?                     |review+
              Flags|                            |

--- Comment #11 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 372453
  --> https://bugs.webkit.org/attachment.cgi?id=372453
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372453&action=review

> Source/WebKit/NetworkProcess/glib/WebKitCachedResolver.cpp:38
> +typedef struct {
> +    GRefPtr<GResolver> wrappedResolver;
> +    DNSCache cache;
> +} WebKitCachedResolverPrivate;

OK you're right, I suppose WebKitCachedResolver is threadsafe because both its data members are.

I recommend adding a comment here to warn about this, otherwise it would be really really easy to mess this up in the future by adding a non-threadsafe member here without a lock.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190620/dc94561e/attachment.html>