[Webkit-unassigned] [Bug 198707] [GTK] The Previous/Next gesture should handle RTL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198707

--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Alexander Mikhaylenko from comment #2)
> Nevermind, it seems to be flipped for RTL pages only.
> 
> However, `m_webPageProxy.userInterfaceLayoutDirection()` seems to always
> return LTR direction, which is why it doesn't work.
> 
> I wonder if it would work with an actual RTL locale.

Currently we have this in our PageClientImpl.h:

WebCore::UserInterfaceLayoutDirection userInterfaceLayoutDirection() override { return WebCore::UserInterfaceLayoutDirection::LTR; }

Something like this in our PageClientImpl.cpp would probably suffice:

WebCore::UserInterfaceLayoutDirection PageClientImpl::userInterfaceLayoutDirection()
{
    return gtk_widget_get_direction(m_viewWidget) == GTK_TEXT_DIR_RTL ?
        WebCore::UserInterfaceLayoutDirection::RTL : WebCore::UserInterfaceLayoutDirection::LTR;
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190620/dd2ac500/attachment.html>