[Webkit-unassigned] [Bug 199066] [GTK] Stop pretending WebCore::Widget can have a platform widget

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 20 06:56:01 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=199066

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com
 Attachment #372550|review?                     |review+
              Flags|                            |

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 372550
  --> https://bugs.webkit.org/attachment.cgi?id=372550
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372550&action=review

Wow, this survived a really long time.

> Source/WebKit/ChangeLog:8
> +        Rename PlatformWidget as PlatformViewWidget to avoid conflict with PlatformWidget defined in WebCore.

Perhaps you hit a unified build issue? WebCore::PlatformWidget and WebKit::PlatformWidget are not the same and should not conflict except when a source file that is using namespace WebCore; gets unified into another source file that isn't expecting it.

Anyway, this change is harmless and I think we can skirt the owner rules if it's a build issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190620/01b5251f/attachment-0001.html>


More information about the webkit-unassigned mailing list