[Webkit-unassigned] [Bug 199065] [GTK] Remove support for GTK2 plugins
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 20 03:35:50 PDT 2019
https://bugs.webkit.org/show_bug.cgi?id=199065
Adrian Perez <aperez at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |aperez at igalia.com
--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 372549
--> https://bugs.webkit.org/attachment.cgi?id=372549
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=372549&action=review
Informally reviewing... Looks good to me, with a small question.
Indeed it's 2019 — it makes me smile to see this go away.
> Source/WTF/wtf/glib/GTypedefs.h:-82
> -
Kinda amazing that this slipped in and stayed around so long.
Good catch.
> Source/WebKit/PlatformGTK.cmake:-469
> - PRIVATE
Is there any reason to remove the “PRIVATE” here? IIUC the GTK
Unix printing library would be still fine linked as such.
> Source/WebKit/SourcesGTK.txt:-27
> -
Great to see more sources built unified, yay!
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190620/2bf9d725/attachment-0001.html>
More information about the webkit-unassigned
mailing list