[Webkit-unassigned] [Bug 198080] webkitgtk 2.24.2 fails to build w/gstreamer 1.12.5

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198080

--- Comment #3 from Philippe Normand <pnormand at igalia.com> ---
(In reply to Mike Gorse from comment #2)
> I'm not super familiar with gstreamer / don't know whether this is the
> right fix or not, but I just noticed that it wouldn't be the only place
> where we do this. mediaPlayerPrivateGStreamerBase.cpp has this:
> #define GST_USE_UNSTABLE_API
> #include <gst/gl/gl.h>
> #undef GST_USE_UNSTABLE_API
> 
> We could also condition it with #if !GST_CHECK_VERSION(1, 14, 0)

That include is already wrapped by #if USE(GSTREAMER_GL). I know the ifdef soup there is already confusing enough.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190619/3308dc1e/attachment-0001.html>