[Webkit-unassigned] [Bug 198995] [GTK] Enable navigation swipe layout tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 19 09:23:57 PDT 2019


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |mcatanzaro at igalia.com

--- Comment #7 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Alexander Mikhaylenko from comment #6)
> Hm, agree. However, when you pass a row pointer to gtk_widget_event(),
> GUniquePtr destroys it before it can be used.

Er, what did you mean here? Did you mean to say "raw pointer"?

You currently have:

GdkEvent* event = createScrollEvent(m_webPageProxy.viewWidget(), delta, 0);
gtk_widget_event(m_webPageProxy.viewWidget(), event);
return true;

The suggested fix is:

GUniquePtr<GdkEvent> event(createScrollEvent(m_webPageProxy.viewWidget(), delta, 0);
gtk_widget_event(m_webPageProxy.viewWidget(), event.get()); // event still valid
return true; // event destroyed here

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190619/615dcb1c/attachment.html>

More information about the webkit-unassigned mailing list