[Webkit-unassigned] [Bug 198995] [GTK] Enable navigation swipe layout tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 19 05:59:01 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=198995

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 372455
  --> https://bugs.webkit.org/attachment.cgi?id=372455
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372455&action=review

> Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:443
> +    GdkEvent* event = createScrollEvent(m_webPageProxy.viewWidget(), delta, 0);

This event is leaked, I think. Better use GUniquePtr to ensure we don't leak it.

> Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:451
> +    GdkEvent* event = createScrollEvent(m_webPageProxy.viewWidget(), 0, 0);

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190619/e5591852/attachment.html>


More information about the webkit-unassigned mailing list