[Webkit-unassigned] [Bug 198829] [GTK] Stop accessing GdkEvent fields when possible

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 14 06:48:24 PDT 2019


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #372116|review?                     |review+
              Flags|                            |

--- Comment #12 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 372116
  --> https://bugs.webkit.org/attachment.cgi?id=372116

View in context: https://bugs.webkit.org/attachment.cgi?id=372116&action=review


> Source/WebCore/platform/gtk/PlatformMouseEventGtk.cpp:58
> -    m_position = IntPoint((int)event->x, (int)event->y);
> -    m_globalPosition = IntPoint((int)event->x_root, (int)event->y_root);
> +    m_position = IntPoint((int)x, (int)y);
> +    m_globalPosition = IntPoint((int)rootX, (int)rootY);

Preexisting problem, but since you're modifying these lines, change them to static_cast because C-style casts aren't allowed in WebKit.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190614/bc91296c/attachment.html>

More information about the webkit-unassigned mailing list