[Webkit-unassigned] [Bug 198838] New: [WHLSL] Ensure MakeArrayReferenceExpression works

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198838

            Bug ID: 198838
           Summary: [WHLSL] Ensure MakeArrayReferenceExpression works
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebGPU
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sbarati at apple.com
                CC: dino at apple.com, fpizlo at apple.com, jonlee at apple.com,
                    justin_fan at apple.com, mmaxfield at apple.com,
                    rmorisset at apple.com

There's some iffy looking code in metal codegen. E.g:

    if (is<AST::PointerType>(makeArrayReferenceExpression.resolvedType()))
        m_stringBuilder.append(makeString(mangledTypeName, ' ', variableName, " = { ", lValue, ", 1 };\n"));


I think it should instead be something like " = lvalue"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190613/74c3e2f6/attachment.html>