[Webkit-unassigned] [Bug 198832] twitch.tv: embedded video hovers down the screen when scrolling on iPad

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198832

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372056|review?                     |review+
              Flags|                            |

--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 372056
  --> https://bugs.webkit.org/attachment.cgi?id=372056
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372056&action=review

>> Source/WebCore/rendering/RenderLayer.cpp:2522
>> +                    paintParent->setDescendantsNeedUpdateBackingAndHierarchyTraversal();
> 
> This might be a stupid question, but... In the case where paintParent is null, shouldn't we still setDescendantsNeedUpdateBackingAndHierarchyTraversal() on ourselves?
> 
> auto* layer = paintOrderParent() ? paintOrderParent() : this;
> layer->setDescendantsNeedUpdateBackingAndHierarchyTraversal();

paintOrderParent() is only null for RenderView, so that should never hit this code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190613/e2ec7e71/attachment.html>