[Webkit-unassigned] [Bug 198832] twitch.tv: embedded video hovers down the screen when scrolling on iPad

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198832

Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ggaren at apple.com

--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 372056
  --> https://bugs.webkit.org/attachment.cgi?id=372056
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372056&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2522
> +                if (auto* paintParent = paintOrderParent())
> +                    paintParent->setDescendantsNeedUpdateBackingAndHierarchyTraversal();

This might be a stupid question, but... In the case where paintParent is null, shouldn't we still setDescendantsNeedUpdateBackingAndHierarchyTraversal() on ourselves?

auto* layer = paintOrderParent() ? paintOrderParent() : this;
layer->setDescendantsNeedUpdateBackingAndHierarchyTraversal();

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190613/1d9db855/attachment.html>