[Webkit-unassigned] [Bug 198604] Refactoring of architectural Register Information

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198604

--- Comment #44 from Paulo Matos <pmatos at igalia.com> ---
(In reply to Keith Miller from comment #43)
> Comment on attachment 371945 [details]
> Post-1 Review Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371945&action=review
> 
> >>> Source/JavaScriptCore/assembler/ARM64Registers.h:31
> >>> +#define REGISTER_NAMESPACE ARM64Registers
> >> 
> >> I think this can just be a using RegisterNames = ARM64Registers; 
> >> 
> >> Then any user can just assume all registers are under the generic RegisterNames namespace.
> > 
> > Not sure I understand the suggestion here.
> > You mean, removing the platform dependent namespace name and making the namespace platform independent in both assembler/<arch>Assembler.h and elsewhere?
> 
> I was thinking more that we could have both the platform specific name and
> an independent name.
> 

You mean, using RegisterNames everywhere and defining RegisterNames to be platform specific in the platform specific file? That sounds good. Will fix.

> I meant more that the consumer macro could just take x0 and do any part of
> the n() macro they want.

That is a great suggestion. It will, hopefully, simplify a bunch of things. Will get to it!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190613/87b1545f/attachment.html>