[Webkit-unassigned] [Bug 198788] REGRESSION(r245818): Async scrolling: Fixed position banner jumps around page

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 12 08:42:05 PDT 2019


--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
> It seems weird for ScrollingTreeFixedNode to have to test all its ancestor
> node types. This was the problem that the old delta was trying to solve, I
> think; these ancestors should pass state down the tree for the
> applyLayerPositions() tree walk.

The old approach had multiple problems. It didn't work unless update started from the root (which it doesn't in most cases). It couldn't handle sticky without additional parameters. 

This is much easier to reason about and when we have decent test coverage we can factor this differently.

> > Source/WebCore/rendering/RenderLayerCompositor.cpp:3057
> > +        if (ancestor->hasCompositedScrollableOverflow())
> > +            return true;
> But this might not be in the ancestor paint order chain. A simple fixed ->
> non-stacking overflow -> fixed should not need to composite the inner fixed.
> I think we only need to composite the inner fixed if some paint-order
> ancestor has a scrolling tree node (but we can't do that check at this
> stage).

Unnecessary nodes should be harmless. You'll probably need to write the optimal version of this.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190612/fee00152/attachment-0001.html>

More information about the webkit-unassigned mailing list