[Webkit-unassigned] [Bug 198604] Refactoring of architectural Register Information

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198604

--- Comment #33 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 371945
  --> https://bugs.webkit.org/attachment.cgi?id=371945
Post-1 Review Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371945&action=review

> Source/JavaScriptCore/assembler/ARM64Registers.h:31
> +#define REGISTER_NAMESPACE ARM64Registers

I think this can just be a using RegisterNames = ARM64Registers; 

Then any user can just assume all registers are under the generic RegisterNames namespace.

> Source/JavaScriptCore/assembler/ARM64Registers.h:55
> +    macro_forward(macro, n(x0), 0, 0)                           \

Why do we need to have the macro_forward? Can't the consumer macro do any of the things n() does? Seems like that would be cleaner.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190612/4026d5e2/attachment.html>