[Webkit-unassigned] [Bug 198604] Refactoring of architectural Register Information

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198604

--- Comment #23 from Paulo Matos <pmatos at igalia.com> ---
(In reply to Don Olmstead from comment #20)
> (In reply to Paulo Matos from comment #17)
> > What are the architectural differences between win and wincairo which could
> > make win pass and wincairo fail? I am unable to reproduce it on a local
> > windows machine. Therefore I am marking the patch for review. Style problems
> > are due to false positives reported in:
> > https://bugs.webkit.org/show_bug.cgi?id=198605
> 
> It appears we're hitting differences between the preprocessor with MSVC and
> Clang/GCC. Chris is working out a fix and it looks like technically MSVC has
> an experimental preprocessor,
> https://devblogs.microsoft.com/cppblog/msvc-preprocessor-progress-towards-
> conformance/ , without this issue.
> 
> Anyways if you can wait to see if Chris can get a version without the issue
> that would be appreciated.

You're right! Thanks for the reference. This exact issue is discussed in the article you posted under the header: Behavior 4 [comma elision in variadic macros]

Like Chris said, why this didn't fail for win EWS is a mystery to me but thanks for looking into it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190612/f56e1c17/attachment-0001.html>