[Webkit-unassigned] [Bug 198747] [WinCairo] Make objects used in CurlRequest thread safe.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198747

--- Comment #13 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #9)
> > Source/WebCore/platform/network/curl/CurlResourceHandleDelegate.h:55
> >      void curlDidReceiveResponse(CurlRequest&, const CurlResponse&) final;
> 
> You should change "const CurlResponse&" to "CurlResponse&&" for consistency
> and efficiency in the future.

Changed.

> > Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp:112
> > +    m_networkLoadMetrics = response.networkLoadMetrics;
> 
> I don't like this copy. I prefer the original code because it uses "&&".

Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190612/a88a940f/attachment.html>