[Webkit-unassigned] [Bug 198764] LayoutTests/fast/events/touch/ios/double-tap-for-double-click* test cases are failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198764

Wenson Hsieh <wenson_hsieh at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #371871|review?                     |review+
              Flags|                            |

--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 371871
  --> https://bugs.webkit.org/attachment.cgi?id=371871
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371871&action=review

r=mews

> Source/WebKit/Shared/WebPageCreationParameters.cpp:295
> +    if (!decoder.decode(parameters.doubleClickForDoubleTapDelay))

Nit - doubleTapForDoubleClick* sounds a bit more appropriate.

> Source/WebKit/Shared/WebPageCreationParameters.h:161
> +    double doubleClickForDoubleTapDelay { 350 };

Nit - Seconds

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:809
> +    auto distanceBetweenTaps = sqrtf(pow(m_potentialTapLocation.x() - m_lastCommittedTapLocation.x(), 2) + pow(m_potentialTapLocation.y() - m_lastCommittedTapLocation.y(), 2));

Nit - you could probably just subtract the points and use diagonalLengthSquared.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190611/a82bba75/attachment-0001.html>