[Webkit-unassigned] [Bug 177398] JSC should throw if proxy set returns falsish in strict mode context

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=177398

--- Comment #10 from Yusuke Suzuki <ysuzuki at apple.com> ---
(In reply to Alexey Shvayka from comment #9)
> Thanks for thorough review, Yusuke.
> It is a bit unusual to handle JS abrupt completions while remembering to
> early return in native code manually and not accidentally override JS
> exception.
> I will be adding tests for this case to Test262: there are quite a few
> operators that do [[Set]] and I would need test generation tooling to cover
> them all (w/o too much repetition).

You can test it by returning `false` from Proxy's [[Set]] operation and checking the error is thrown. Actually we modified regexp-match-proxy.js etc., because this patch changes the behavior of that tests. So you can craft the test by using the similar way done in regexp-match-proxy.js.

While we have test262 for spec compatibility checking, we also would like to have a test in JSC's JSTests/ to (1) avoid accidentally causing the regression in very implementation detailed way, and to (2) ensure the current JSC's assuming behavior even after the spec is changed :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190611/4fd8cd85/attachment.html>