[Webkit-unassigned] [Bug 197971] GLContextEGL should check the supported EGL version at compile time

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197971

--- Comment #24 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Maybe we have a misunderstanding.

Your code starts like this:

        if (platformDisplay.eglCheckVersion(1, 5)
            || (platformDisplay.eglCheckVersion(1, 4) && GLContext::isExtensionSupported(extensions, "EGL_KHR_create_context"))) {
                contextAttributes[0] = EGL_CONTEXT_MAJOR_VERSION_KHR;
                contextAttributes[1] = 3;
                contextAttributes[2] = EGL_CONTEXT_MINOR_VERSION_KHR;

with eight spaces of indentation between the if and the code within the condition. But to be accepted into WebKit, it needs to look like this:

        if (platformDisplay.eglCheckVersion(1, 5)
            || (platformDisplay.eglCheckVersion(1, 4) && GLContext::isExtensionSupported(extensions, "EGL_KHR_create_context"))) {
            contextAttributes[0] = EGL_CONTEXT_MAJOR_VERSION_KHR;
            contextAttributes[1] = 3;
            contextAttributes[2] = EGL_CONTEXT_MINOR_VERSION_KHR;

with four spaces.

Similarly, your code ends like this:

                // Try to create a context with this configuration.
                context = eglCreateContext(platformDisplay.eglDisplay(), config, sharingContext, contextAttributes);
        }

again, with eight spaces there. But it needs to use four spaces:

            // Try to create a context with this configuration.
            context = eglCreateContext(platformDisplay.eglDisplay(), config, sharingContext, contextAttributes);
        }

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190608/6ad3fedf/attachment.html>