[Webkit-unassigned] [Bug 198646] WebProcessProxy didFinishLaunching - invalid connection identifier (web process failed to launch)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198646

--- Comment #5 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
(In reply to mitz from comment #4)
> (In reply to Frédéric Wang (:fredw) from comment #3)
> > Created attachment 371570 [details]
> > DiagnosticReports
> 
> Thank you. Right there near the top:

Ah, yes :-)

> The built Networking service is linking against the preinstalled WebKit
> framework rather than against the built framework.
> 
> To help diagnose this, you can try changing setupIOSWebKitEnvironment() in
> webkitdirs.pm to also set the __XPC_-prefixed environment variables (like
> setupMacWebKitEnvironment() does).

Right, setting them fixes the crash:

diff --git a/Tools/Scripts/webkitdirs.pm b/Tools/Scripts/webkitdirs.pm
index 67cc17a6b1..b8b083c9bd 100755
--- a/Tools/Scripts/webkitdirs.pm
+++ b/Tools/Scripts/webkitdirs.pm
@@ -2468,7 +2468,9 @@ sub setupIOSWebKitEnvironment($)
     $dyldFrameworkPath = File::Spec->rel2abs($dyldFrameworkPath);

     prependToEnvironmentVariableList("DYLD_FRAMEWORK_PATH", $dyldFrameworkPath);
+    prependToEnvironmentVariableList("__XPC_DYLD_FRAMEWORK_PATH", $dyldFrameworkPath);
     prependToEnvironmentVariableList("DYLD_LIBRARY_PATH", $dyldFrameworkPath);
+    prependToEnvironmentVariableList("__XPC_DYLD_LIBRARY_PATH", $dyldFrameworkPath);

     setUpGuardMallocIfNeeded();
 }

>  Also, check the LC_DYLD_ENVIRONMENT
> commands in the output of "otool -lv
> com.apple.WebKit.Networking.Development" and see if the one that’s relative
> to @executable_path would lead to where the built framework is.

I'm not sure I understand that one, but the command in WebKitBuild/Debug-iphonesimulator/com.apple.WebKit.Networking.xpc gives:

Load command 19
          cmd LC_DYLD_ENVIRONMENT
      cmdsize 64
         name DYLD_FRAMEWORK_PATH=@executable_path/../../.. (offset 12)
Load command 20
          cmd LC_DYLD_ENVIRONMENT
      cmdsize 64
         name DYLD_LIBRARY_PATH=@executable_path/../../Frameworks (offset 12)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190607/7124b743/attachment.html>