[Webkit-unassigned] [Bug 198639] New: Web Inspector: Timelines: only complete Composite records if the m_startedComposite (followup to r 246142)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 6 19:03:44 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=198639

            Bug ID: 198639
           Summary: Web Inspector: Timelines: only complete Composite
                    records if the m_startedComposite (followup to r
                    246142)
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: drousso at apple.com
                CC: inspector-bugzilla-changes at group.apple.com

In r246142, an `ASSERT` was removed because it is possible for Web Inspector to be opened in between `willComposite` and `didComposite`, meaning that previously the `ASSERT` would fire.  In order to properly handle this, we should replace the `ASSERT` with an `if` so that we don't even try to complete a `Composite` record if Web Inspector is opened in that case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190607/72178861/attachment.html>


More information about the webkit-unassigned mailing list