[Webkit-unassigned] [Bug 198630] Three checks are missing in Proxy internal methods

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198630

--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 371538
  --> https://bugs.webkit.org/attachment.cgi?id=371538
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371538&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        These checks are needed to maintain the invariants of the essential internal methods.

can you also list what exactly they are here?

> Source/JavaScriptCore/runtime/ProxyObject.cpp:666
> +        bool targetIsExtensible = target->isExtensible(exec);

can you add a test here where this does effects to ensure it's being tested? Also, is the ordering of these effects correct? Is this when this effect is supposed to happen in the spec?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190607/dae40f08/attachment.html>