[Webkit-unassigned] [Bug 198093] [CMake] Build with hidden visibility by default

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198093

--- Comment #13 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 371357
  --> https://bugs.webkit.org/attachment.cgi?id=371357
WIP Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371357&action=review

> Source/JavaScriptCore/CMakeLists.txt:121
> +    -lpthread

No doubt this is perfectly idiomatic CMake. Yup. :P

> Source/JavaScriptCore/CMakeLists.txt:1317
> +get_target_property(link_props JavaScriptCore INTERFACE_LINK_LIBRARIES)
> +message("${link_props}")
> +list(REMOVE_ITEM link_props WTF bmalloc -Wl,--whole-archive -Wl,--no-whole-archive)
> +message("${link_props}")
> +set_target_properties(JavaScriptCore PROPERTIES INTERFACE_LINK_LIBRARIES "${link_props}")

Heh, well, awful as this is, I'm quite impressed that you succeeded. I'm excited for -fvisibility=hidden!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190605/8e6ffc7a/attachment.html>