[Webkit-unassigned] [Bug 198093] [CMake] Build with hidden visibility by default

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198093

--- Comment #11 from Don Olmstead <don.olmstead at sony.com> ---
(In reply to Fujii Hironori from comment #10)
> Comment on attachment 371357 [details]
> WIP Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371357&action=review
> 
> > Source/JavaScriptCore/CMakeLists.txt:125
> > +    -Wl,--no-whole-archive
> 
> OBJECT library is better way to do it in CMake. See Bug 196866.

Chris is hitting https://gitlab.kitware.com/cmake/cmake/issues/18010 when using object libraries. Ubuntu comes with 3.10 but the fix came in 3.12

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190605/9e3fad81/attachment.html>