[Webkit-unassigned] [Bug 198093] [CMake] Build with hidden visibility by default

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198093

--- Comment #8 from Christopher Reid <chris.reid at sony.com> ---
It looks like most of these cases are sorted out if we link WTF and bmalloc static libraries as whole archives
when building libjavascriptcoregtk.so then stop linking to those static libraries and just link to libjavascriptcoregtk.so later on.

The WKTR PerProcess deadlock was because WKTR was directly linking to libWTFGTK.a in its _LIBRARIES and it was preceding libjavascriptcoregtk.so in the link command
so functions were getting linked from there before libjavascriptcoregtk.so.

If we stop linking to bmalloc and WTF after building libjavascriptcoregtk.so then most of these issues will become build errors because of missing exports instead of subtle runtime issues.
The only instances of duplicated local .bss symbols after doing that is with statics defined in headers.
Specifically these `cached` statics are the only duplicated symbols I'm seeing now https://github.com/WebKit/webkit/blob/master/Source/bmalloc/bmalloc/VMAllocate.h#L57.

I'll upload my WIP patch with cmake hacked together to stop linking to bmalloc and WTF static libs after libjavascriptcoregtk.so is built.
Don was looking at ways to achieve that properly in cmake.
I haven't been able to run layout tests on it yet since GTK layout tests are red at the moment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190605/40009f26/attachment-0001.html>