[Webkit-unassigned] [Bug 198466] [WinCairo] Implement cpu and memory measuring functions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198466

--- Comment #13 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Don Olmstead from comment #10)
> (In reply to Don Olmstead from comment #9)
> > (In reply to Don Olmstead from comment #8)
> > > Comment on attachment 371237 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=371237&action=review
> > > > Source/cmake/OptionsWinCairo.cmake:35
> > > > +set(ENABLE_RESOURCE_USAGE ON)
> > > 
> > > This is a WebKit option so this should be moved to OptionsWin.cmake in the
> > > `if (${WTF_PLATFORM_WIN_CAIRO})` block in between WEBKIT_OPTION_BEGIN() and
> > > WEBKIT_OPTION_END()
> > > 
> > > ```
> > > WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE OFF)
> > > ```
> > 
> > Sorry ON not OFF. Copy paste error...
> 
> Actually can you add it to the experimental features list till we have the
> full implementation.
> 
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE
> ${ENABLE_EXPERIMENTAL_FEATURES})

FIXED.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190604/c8aa71c5/attachment-0001.html>