[Webkit-unassigned] [Bug 198466] [WinCairo] Implement cpu and memory measuring functions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198466

--- Comment #8 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 371237
  --> https://bugs.webkit.org/attachment.cgi?id=371237
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371237&action=review

Couple nits but LGTM overall. Fujii could you take another pass?

> Source/WebCore/page/win/ResourceUsageThreadWin.cpp:116
> +    // FIXME: Exclude the ResourceUsage thread.
> +    // FIXME: Exclude the SamplingProfiler thread.
> +    // FIXME: Classify usage per thread.
> +    data.cpuExcludingDebuggerThreads = data.cpu;

Could you open up a bug for this work and then link to it?

> Source/cmake/OptionsWinCairo.cmake:35
> +set(ENABLE_RESOURCE_USAGE ON)

This is a WebKit option so this should be moved to OptionsWin.cmake in the `if (${WTF_PLATFORM_WIN_CAIRO})` block in between WEBKIT_OPTION_BEGIN() and WEBKIT_OPTION_END()

```
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE OFF)
```

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190604/5149e951/attachment.html>