[Webkit-unassigned] [Bug 198466] [WinCairo] Implement cpu and memory measuring functions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198466

--- Comment #6 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #2)
> Comment on attachment 371142 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371142&action=review
> 
> > Source/WebCore/PlatformWinCairo.cmake:16
> > +    page/win/ResourceUsageThreadWinCairo.cpp
> 
> Rename *Win.cpp.

Renamed.

> > Source/WebCore/page/win/ResourceUsageThreadWinCairo.cpp:43
> > +uint64_t fileTimeToUint64(FILETIME ft)
> 
> Mark these file-local functions "static".

Marked.

> > Tools/WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:-40
> > -    return JSStringCreateWithUTF8CString("");
> 
> What about using UrlCreateFromPath?
> https://docs.microsoft.com/en-us/windows/desktop/api/shlwapi/nf-shlwapi-
> urlcreatefrompatha

Changed to use UrlCreateFromPathW.

> > Tools/WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:44
> > +        _wsplitpath(exePath, drive, dir, nullptr, nullptr);
> 
> Why do you need to split first?

We need to determine resource directory path.
This part makes the path by splitting absolute path of WebKitTestRunner.exe.

> > Tools/WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:52
> > +        char stubPathUTF8[MAX_PATH];
> 
> MAX_PATH shouldn't be used for UTF-8 buffer length. How about using
> JSStringCreateWithCharacters? Then, you don't need to convert to UTF-8.

Changed.

> > LayoutTests/platform/wincairo/TestExpectations:1566
> >  inspector [ Skip ]
> 
> Can you unskip all inspector tests? How much failure will occur? If you
> can't unskip inspector tests, I think you should change the summary of this
> bug.

Changed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190604/7bed394e/attachment-0001.html>