[Webkit-unassigned] [Bug 199938] [WinCairo] Start RemoteInspectorServer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199938

--- Comment #11 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 375279
  --> https://bugs.webkit.org/attachment.cgi?id=375279
Updated WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375279&action=review

Looks a great improvement. Good job!

The issue of racy initial empty target list should be filed as separate bug ticket.

> Source/WebKit/UIProcess/socket/RemoteInspectorClient.h:88
> +    URL m_url;

This is not used anymore.

> Source/WebKit/UIProcess/socket/RemoteInspectorProtocolHandler.cpp:100
> +    // Re-create the connection to avoid holding on to bad connections

If you re-create RemoteInspectorClient every time inspector:// is load, we don't need to manage RemoteInspectorClient instances by using a HashMap m_inspectorClients anymore.

> Source/WebKit/UIProcess/socket/RemoteInspectorProtocolHandler.cpp:165
> +        "}"

I think we should have just only one JS function.
       "function updateTargets(str) {"
            "let targetDiv = document.getElementById('targetlist');"
            "targetDiv.innerHTML = str"
        "}"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190801/caba901a/attachment.html>