[Webkit-unassigned] [Bug 191498] [Curl] implement CertificateInfo::summaryInfo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191498

--- Comment #36 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #34)
> Comment on attachment 375068 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=375068&action=review
> 
> > Source/WebCore/platform/network/curl/OpenSSLHelper.cpp:46
> > +using X509Ref = std::unique_ptr<X509, deleter<X509>>;
> 
> I don't think X509Ref is a good name because this is not ref-counted object
> and this can be nullptr.
> I think you don't need to type aliasing becuase this type is used only once.

Removed type aliasing.

> > Source/WebCore/platform/network/curl/OpenSSLHelper.cpp:138
> > +        if (auto x509 = ::PEM_read_bio_X509(m_bio, nullptr, 0, nullptr))
> 
> return X509Ref(::PEM_read_bio_X509(m_bio, nullptr, 0, nullptr));

Fixed.

> > Source/WebCore/platform/network/curl/OpenSSLHelper.cpp:184
> > +    return WTFMove(result);
> 
> You should remove WTFMove.
> return result;
> https://lists.webkit.org/pipermail/webkit-dev/2019-March/030548.html

Fixed.

> > Source/WebCore/platform/network/curl/OpenSSLHelper.cpp:205
> > +    auto commonName = toString(commonNameEntryData);
> 
> How about simply returning the return value of toString?
> return toString(commonNameEntryData);

Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190801/57b15d53/attachment.html>