[Webkit-unassigned] [Bug 200306] [GTK][WPE] Fix gtkdoc build with "build-webkit --32-bit" on 64-bit hosts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=200306

--- Comment #4 from Loïc Yhuel <loic.yhuel at softathome.com> ---
(In reply to Michael Catanzaro from comment #3)
> I very nearly set r+ here... but I wonder, should we fix gtk-doc instead?
> Because it's really not right that -m32 should be required in LDFLAGS, is it?
It uses CFLAGS to build the object files, then only LDFLAGS on link (there is no real standard, there are buildsystems which keep CFLAGS for the link, and others which do not).
Also, gtk-doc is disabled when cross-compiling, so multilib is probably borderline.

> (I'm also sure you know not to use build-webkit for production builds. ;)
Well, we still use build-webkit on our downstream target builds (but main compiler flags come from a CMake toolchain file, since it's cross-compiled).
It behaves slightly better for development when there are changes, and having two different ways to build WebKit could lead to differences between what the developer sees, and what the integrator gets.

This commit is only for host builds, ie when we want to upstream patches or compare behavior between our WPE downstream and WPE/GTK upstream. The 32-bit build matters since our targets are still 32-bit (mostly ARMv7, and sometimes mips32r1 and x86).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190731/e0a8fef4/attachment.html>