[Webkit-unassigned] [Bug 113849] [Cairo][SVG] marker-mid isn't shown on a joint of rectilinearly connected line-to path segments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113849

--- Comment #22 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 375221
  --> https://bugs.webkit.org/attachment.cgi?id=375221
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375221&action=review

>> Source/WebCore/platform/graphics/cairo/PathCairo.cpp:56
>> +    *this = other;
> 
> I don't think this is correct. CairoPath contains a RefPtr<cairo_context_t>, so we will end up with two Paths having the same cairo context.

This calls Path::operator=. It does deep copy.

>> Source/WebCore/platform/graphics/cairo/PlatformPathCairo.h:155
>> +};
> 
> I think a single class would be simpler, we just need a switch in transform and translate to decide whether to use 1, 2, or 3 points.

Yeah, I think so.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190731/50f5876f/attachment.html>