[Webkit-unassigned] [Bug 200163] JPEGImageDecoder: use libjpeg-turbo RGBA output path even for Adobe transform=0 JPEGs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 30 11:22:18 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=200163

--- Comment #15 from Loïc Yhuel <loic.yhuel at softathome.com> ---
(In reply to Alex Christensen from comment #14)
> Comment on attachment 374964 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=374964&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        Covered by existing fast/images/rgb-jpeg-with-adobe-marker-only.html.
> 
> If it's covered by this test, should we see an update of the test
> expectations with this change?

https://trac.webkit.org/changeset/108870/webkit added the test and the workaround (RGB output, converted to RGBA in WebKit, like with the IJG libjpeg), so the test always passed.

My patch removes the workaround when we have libjpeg-turbo >= 1.2.1.

The test would only fail if we force RGBA decoding with a libjpeg-turbo < 1.2.1.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190730/59a408af/attachment.html>


More information about the webkit-unassigned mailing list