[Webkit-unassigned] [Bug 200162] [SOUP] Switch to use libsoup WebSockets API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=200162

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #374961|review?                     |review+
              Flags|                            |

--- Comment #9 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 374961
  --> https://bugs.webkit.org/attachment.cgi?id=374961
Patch

Me too, so much so that I forgot I had not already given r+....

Just one thing: the end goal should be to remove SocketStreamHandleImpl altogether for platforms with platform-native sockets, not leave it with RELEASE_ASSERTs. This means that we might need to eventually introduce a new build flag, something like #if USE(PLATFORM_WEBSOCKETS) that will be equivalent to #if HAVE(NSURLSESSION_WEBSOCKET) || USE(SOUP). But that can be future.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190730/ad76cee3/attachment-0001.html>