[Webkit-unassigned] [Bug 200076] [SOUP] Move SoupNetworkSession ownership from NetworkStorageSession to NetworkSession

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 30 07:36:49 PDT 2019


--- Comment #14 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 374955
  --> https://bugs.webkit.org/attachment.cgi?id=374955
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=374955&action=review

>> Source/WebKit/NetworkProcess/NetworkProcess.cpp:278
>> +    forEachNetworkSession([](NetworkSession& networkSession) {
> auto& here and below.


>> Source/WebKit/NetworkProcess/NetworkStorageSessionProvider.h:57
>> +    SoupSession* soupSession() const final
> This seems only called in one place right now.
> Maybe instead, we could simply add a cross-platform NetworkSession* networkSession() const getter and soup specific code would do the static cast.

Yes, it's a temporary solution, it will be removed in bug #200162.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190730/5548bce3/attachment.html>

More information about the webkit-unassigned mailing list