[Webkit-unassigned] [Bug 200169] Expose the aria-label attribute for <video> elements.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=200169

Russell Epstein <repstein at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |repstein at apple.com

--- Comment #8 from Russell Epstein <repstein at apple.com> ---
(In reply to Andres Gonzalez from comment #5)
> (In reply to Darin Adler from comment #3)
> > Comment on attachment 374979 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=374979&action=review
> > 
> > Not sure I’m a qualified reviewer for this. But I do have some comments.
> > 
> > > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:689
> > > +    // Convey the video object as interactive if it is not auto-playing.
> > 
> > This comment says "if it is not auto-playing" but that’s not what the code
> > below does. The code checks if autoplay is allowed, not if it’s actually
> > actively happening.
> > 
> > > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:691
> > > +    auto* mediaObject = downcast<AccessibilityMediaObject>(m_object);
> > > +    return !mediaObject->isAutoplayEnabled();
> > 
> > Now that it gets this simple, we’d normally write it like this:
> > 
> >     return
> > !downcast<AccessibilityMediaObject>(*m_object).isAutoplayEnabled();
> > 
> > I don’t think the two line version is better.
> 
> Thanks Darin, both good points. fixed.

It appears that this patch caused accessibility/ios-simulator/video-elements-ios.html to fail.

This was not caught by EWS because the test has a test expectation, [ Pass Timeout ].

 https://bugs.webkit.org/show_bug.cgi?id=200231

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190729/1d22a020/attachment.html>