[Webkit-unassigned] [Bug 200076] [SOUP] Move SoupNetworkSession ownership from NetworkStorageSession to NetworkSession

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=200076

--- Comment #12 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 374955
  --> https://bugs.webkit.org/attachment.cgi?id=374955
Patch for landing

LGTM, the review flag is not set though.

View in context: https://bugs.webkit.org/attachment.cgi?id=374955&action=review

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:699
> +    networkProcess().forEachNetworkSession([statistics = WTFMove(statistics)](NetworkSession& networkSession) mutable {

auto&
See also https://bugs.webkit.org/show_bug.cgi?id=200225

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:278
> +    forEachNetworkSession([](NetworkSession& networkSession) {

auto& here and below.

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:1372
> +            fetchDiskCacheEntries(session.cache(), sessionID, fetchOptions, [callbackAggregator = WTFMove(callbackAggregator)](auto entries) mutable {

There seems to be a preexisting bug here in case there are more than one session as we move clearTasksHandler several times potentially.

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:1532
> +            clearDiskCacheEntries(session.cache(), originDatas, [clearTasksHandler = WTFMove(clearTasksHandler)] { });

There seems to be a preexisting bug here in case there are more than one session as we move clearTasksHandler several times potentially.

> Source/WebKit/NetworkProcess/NetworkStorageSessionProvider.h:57
> +    SoupSession* soupSession() const final

This seems only called in one place right now.
Maybe instead, we could simply add a cross-platform NetworkSession* networkSession() const getter and soup specific code would do the static cast.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190729/8537cc4a/attachment.html>