[Webkit-unassigned] [Bug 200223] New: [GTK] Compilation error when GL is enabled: updateTextureMapperFlags is not defined.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=200223

            Bug ID: 200223
           Summary: [GTK] Compilation error when GL is enabled:
                    updateTextureMapperFlags is not defined.
           Product: WebKit
           Version: WebKit Local Build
          Hardware: All
                OS: Linux
            Status: NEW
          Keywords: Gtk
          Severity: Major
          Priority: P2
         Component: WebKitGTK
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: k.amini at activevideo.com
                CC: bugs-noreply at webkitgtk.org

Hello,

I receive the following compilation error when the GL support is off. I'm compiling 2.24.3 on a CentOS machine.

> In file included from /usr/include/glib-2.0/gobject/gobject.h:28:0,
>                  from /usr/include/glib-2.0/gobject/gbinding.h:29,
>                  from /usr/include/glib-2.0/glib-object.h:23,
>                  from /opt/activevideo/webkit-dependencies/include/gstreamer-1.0/gst/gstenumtypes.h:7,
>                  from /opt/activevideo/webkit-dependencies/include/gstreamer-1.0/gst/gst.h:31,
>                  from ../Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h:24,
>                  from ../Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:24,
>                  from ../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:29,
>                  from ../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:27:
> ../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: In lambda function:
> ../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2530:17: error: ‘class WebCore::MediaPlayerPrivateGStreamer’ has no member named ‘updateTextureMapperFlags’
>          player->updateTextureMapperFlags();
>                  ^
>  [12/1006] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp.o

Root Cause:
The issue is apparent in the following sources. The `updateTextureMapperFlags` is defined only when `TEXTURE_MAPPER_GL` is used.

Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:247
246 #if USE(TEXTURE_MAPPER_GL)
247     void updateTextureMapperFlags();
248     TextureMapperGL::Flags m_textureMapperFlags;
249 #endif

The following is the definition of the function:

Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:964
963 #if USE(TEXTURE_MAPPER_GL)
964 void MediaPlayerPrivateGStreamerBase::updateTextureMapperFlags()
965 {
966     switch (m_videoSourceOrientation) {
967     case DefaultImageOrientation:
968         m_textureMapperFlags = 0;

And the following is the usage of the function which does not check the `TEXTURE_MAPPER_GL` macro to be set.

Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2491
2489             player->m_videoDecoderPlatform = WebKitGstVideoDecoderPlatform::ImxVPU;
2490
2491         player->updateTextureMapperFlags();
2492     }), this);

Thanks in advance.

Best regards,
Kam

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190729/11e0ea0e/attachment.html>