[Webkit-unassigned] [Bug 191498] [Curl] implement CertificateInfo::summaryInfo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191498

--- Comment #33 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Alex Christensen from comment #31)
> Comment on attachment 374451 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=374451&action=review
> 
> >>> Source/WebCore/platform/network/curl/OpenSSLHelper.cpp:56
> >>> +            OPENSSL_free(*ptr);
> >> 
> >> How do we know there will only be one thing needing OPENSSL_free here?
> > 
> > Do you mean we should consider not only buffer we got from ASN1_STRING_to_UTF8other but also other type objects we have to free with OPENSSL_free?
> 
> If this is only to be used for that type, it should not be in a
> deleter<unsigned char**>, but rather in a class type that can only be used
> for a buffer you got from ASN1_STRING_to_UTF8other

Stopped using deleter<unsigned char**> because we can free buffer locally in convert function.

Stopped using deleter<BUF_MEM> and add getting data functions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190729/54969a7f/attachment.html>