[Webkit-unassigned] [Bug 200122] AX: web process should load correct bundle path for MACCATALYST

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=200122

--- Comment #18 from chris fleizach <cfleizach at apple.com> ---
(In reply to Darin Adler from comment #17)
> Comment on attachment 374925 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=374925&action=review
> 
> > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:328
> > +    NSString *accessibilityBundlePath = (NSString *)GSSystemRootDirectory();
> > +#if PLATFORM(MACCATALYST)
> > +    accessibilityBundlePath = [accessibilityBundlePath stringByAppendingString:@"System/iOSSupport"];
> > +#endif
> > +    accessibilityBundlePath = [accessibilityBundlePath stringByAppendingString:@"System/Library/AccessibilityBundles/WebProcessLoader.axbundle"];
> 
> Seems really unfortunate to have these paths hard-coded here in WebKit open
> source. Is there some way to do this better in the future? Anything in the
> OS that can get us the path to the accessibility bundles directory in a more
> principled way?

Yes this is doable. 

@Eric, can you stage a change in AccessibilitySupport.h that returns the path for this bundle

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190726/d92cede9/attachment.html>