[Webkit-unassigned] [Bug 200169] Expose the aria-label attribute for <video> elements.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 26 12:51:51 PDT 2019


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |darin at apple.com

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 374979
  --> https://bugs.webkit.org/attachment.cgi?id=374979

View in context: https://bugs.webkit.org/attachment.cgi?id=374979&action=review

Not sure I’m a qualified reviewer for this. But I do have some comments.

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:689
> +    // Convey the video object as interactive if it is not auto-playing.

This comment says "if it is not auto-playing" but that’s not what the code below does. The code checks if autoplay is allowed, not if it’s actually actively happening.

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:691
> +    auto* mediaObject = downcast<AccessibilityMediaObject>(m_object);
> +    return !mediaObject->isAutoplayEnabled();

Now that it gets this simple, we’d normally write it like this:

    return !downcast<AccessibilityMediaObject>(*m_object).isAutoplayEnabled();

I don’t think the two line version is better.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190726/64b4778a/attachment-0001.html>

More information about the webkit-unassigned mailing list