[Webkit-unassigned] [Bug 200137] Replace FileSystem::MappedFileData success parameter with returning Optional

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=200137

--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 374916
  --> https://bugs.webkit.org/attachment.cgi?id=374916
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374916&action=review

> Source/JavaScriptCore/runtime/CachedTypes.cpp:195
> +        error = BytecodeCacheError::StandardError(errno);

Not new to this patch, but I worry about the use of "errno" in platform-independent code. Seems like instead of Optional we could use Expected so the error code would be part of the return value rather than in a global variable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190725/813c6007/attachment.html>