[Webkit-unassigned] [Bug 200037] Allow Clients to make an input field considered autofilled and secure while viewable

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 24 19:45:01 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=200037

--- Comment #4 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 374843
  --> https://bugs.webkit.org/attachment.cgi?id=374843
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374843&action=review

Good start, but this patch is missing invalidation logic to handle things like (off the top of my head):

1. Form reset - grep for ::reset
2. When HTML type attribute changes
3. When HTML value attribute changes


(2) and (3) call :: resignStrongPasswordAppearance. <— Grep that, it needs to be patched. Look at all callers, more patching may be needed.

> Source/WebCore/css/html.css:740
> +    background-color: #FAFFBD !important;
> +    background-image: none !important;
> +    color: #000000 !important;

In my opinion I would share with ^^^^ selectors instead of duplicating.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190725/6149ee0b/attachment.html>


More information about the webkit-unassigned mailing list