[Webkit-unassigned] [Bug 174313] Implement EventTarget constructor
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 24 18:39:10 PDT 2019
https://bugs.webkit.org/show_bug.cgi?id=174313
Darin Adler <darin at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |darin at apple.com
Attachment #374820|review? |review+
Flags| |
--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 374820
--> https://bugs.webkit.org/attachment.cgi?id=374820
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=374820&action=review
I like most everything about the patch except for the class name. Could we call it EventTargetConstructible or EventTargetConcrete or something that is more specific than "Impl"?
> Source/WebCore/dom/EventTargetImpl.cpp:30
> +#include <wtf/IsoMallocInlines.h>
Don’t need this since it’s also in the header.
> Source/WebCore/dom/EventTargetImpl.h:41
> + ~EventTargetImpl() = default;
Why is this needed? Won’t this compile fine without this and work properly?
> Source/WebCore/dom/EventTargetImpl.h:45
> + using RefCounted::deref;
> +private:
Normally we’d leave a blank line before "private".
> Source/WebCore/dom/EventTargetImpl.h:46
> + EventTargetImpl(ScriptExecutionContext&);
Should have "explicit" here.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190725/0ea5f865/attachment.html>
More information about the webkit-unassigned
mailing list