[Webkit-unassigned] [Bug 199326] Allow Clients to Add Fields to the AutoFillContext Dictionary

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 24 16:35:29 PDT 2019


Wenson Hsieh <wenson_hsieh at apple.com> changed:

           What    |Removed                     |Added
 Attachment #374812|review?                     |review+
              Flags|                            |

--- Comment #20 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 374812
  --> https://bugs.webkit.org/attachment.cgi?id=374812

View in context: https://bugs.webkit.org/attachment.cgi?id=374812&action=review

This patch looks great. Thanks again for working on the test! Just a couple more very minor nits.

> Tools/ChangeLog:4
> +

Nit - extra newline here.

> Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:532
> +    NSDictionary *expected =  @{ @"strongPasswordAdditionalContext" : @"testUUID" };

Nit - extra space here between = and @

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190724/b0af7d75/attachment.html>

More information about the webkit-unassigned mailing list