[Webkit-unassigned] [Bug 199326] Allow Clients to Add Fields to the AutoFillContext Dictionary

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199326

--- Comment #13 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 374763
  --> https://bugs.webkit.org/attachment.cgi?id=374763
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374763&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:852
> +    _additionalContextForStrongPasswordAssistance = nullptr;

Nit - nil or { } instead of nullptr.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:5317
> +    _additionalContextForStrongPasswordAssistance = nullptr;

(Ditto)

> Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:542
> +    if ([inputDelegate respondsToSelector:@selector(_webViewAdditionalContextForStrongPasswordAssistance:)])

Hmmm I might be missing something here, but shouldn’t TestInputDelegate implement -_webViewAdditionalContextForStrongPasswordAssistance: with something like:

- (NSDictionary<id, NSString *> *)_webViewAdditionalContextForStrongPasswordAssistance:(WKWebView *)webView
{
    if (_webViewAdditionalContextForStrongPasswordAssistance)
        return _webViewAdditionalContextForStrongPasswordAssistance(webView);
    return @{ };
}

…and then we would check the value of [[webView textInputContentView] _autofillContext] after focusing a password field?

You’ll probably also need to implement -_webView:_focusRequiresStrongPasswordAssistance: on TestInputDelegate, and return YES in this case.

> Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:547
> +    ASSERT([_additionalContextForStrongPasswordAssistance isEqualToDictionary:expected]);

This should be EXPECT_TRUE.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190724/e815c1ad/attachment.html>