[Webkit-unassigned] [Bug 191498] [Curl] implement CertificateInfo::summaryInfo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191498

--- Comment #31 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 374451
  --> https://bugs.webkit.org/attachment.cgi?id=374451
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374451&action=review

>>> Source/WebCore/platform/network/curl/OpenSSLHelper.cpp:56
>>> +            OPENSSL_free(*ptr);
>> 
>> How do we know there will only be one thing needing OPENSSL_free here?
> 
> Do you mean we should consider not only buffer we got from ASN1_STRING_to_UTF8other but also other type objects we have to free with OPENSSL_free?

If this is only to be used for that type, it should not be in a deleter<unsigned char**>, but rather in a class type that can only be used for a buffer you got from ASN1_STRING_to_UTF8other

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190723/1c69c496/attachment.html>