[Webkit-unassigned] [Bug 199938] [WinCairo] Start RemoteInspectorServer
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jul 21 20:17:12 PDT 2019
https://bugs.webkit.org/show_bug.cgi?id=199938
--- Comment #6 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 374455
--> https://bugs.webkit.org/attachment.cgi?id=374455
WIP patch
View in context: https://bugs.webkit.org/attachment.cgi?id=374455&action=review
>> Source/WebKit/Shared/WebProcessCreationParameters.cpp:154
>> +#if ENABLE(REMOTE_INSPECTOR) && PLATFORM(WIN)
>
> Shouldn’t this be USE(INSPECTOR_SOCKET_SERVER) not PLATFORM(WIN)?
Umm, in Unix, it uses unix domain sockets instead of BSD sockets.
>> Source/WebKit/Shared/WebProcessCreationParameters.h:193
>> + uint16_t m_inspectorServerPort { 0 };
>
> Should be inspectorServerPort in POD.
Oops. Thanks.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190722/1fdc5a0b/attachment.html>
More information about the webkit-unassigned
mailing list