[Webkit-unassigned] [Bug 199973] Add accessibilityInsertText for text insertion in edit fields.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 19 17:39:17 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=199973

--- Comment #2 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 374529
  --> https://bugs.webkit.org/attachment.cgi?id=374529
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374529&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:2289
> +    if (element.shouldUseInputMethod()) {

we should do early return styleher

if (!element.shouldUseInputMethod())
    return false;

> Source/WebCore/accessibility/AccessibilityObject.h:717
> +    bool insertText(const String& text);

no need to name parameter here

> LayoutTests/accessibility/insert-newline.html:16
> +        content.focus();

is this the same exact test on iOS? if so we can probably share it  in accessibility folder and skip on other platforms

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190720/a03a62ae/attachment.html>


More information about the webkit-unassigned mailing list